Design comparison
Solution retrospective
Hi, still got some issues with the work, I can't change the placeholder when email error is given and even when some input are filled the error still runs on all of them, I'm sure is because I used a for loop that's why it's giving me problems. Anyway JavaScript looks hard.
Feedback appreciated Thank you.
Community feedback
- @jameslegoff92Posted about 2 years ago
Hi there Osauyi,
Good effort on this project but I noticed a few things. Your project breaks on different screen sizes and the form validation needs to be fixed. I have a few suggestions that I think will make your life a lot easier.
-
Add the CSS property "box-sizing: border-box" to all html elements by using the '*' selector. This will make sure that your elements respect the size you want them to be, even if you add padding. If you want to learn more about it. https://www.w3schools.com/cssref/css3_pr_box-sizing.php
-
Get rid of the min-width for your input elements on your form and use width with a percentage value. This will make your input size responsive. You want this because it will allow your input fields to adjust to the appropriate size based on the user's device.
-
Add a min-width value to your body element. This will make your project look good even on much smaller screen sizes. I usually put a min-width of 365-375px. This is the size I need my project to be in order for the content to still be proportional.
With a few changes made to your code you could make your project fully responsive. If you can't these tips don't suffice and you need more hints, feel free to respond here and I will help you out.
Happy Coding!
Marked as helpful1@OsauyiPosted about 2 years ago@jameslegoff92 Thanks, I'll go read more about form validation and also apply them in my next proj.
Thanks once again.0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord