Skip to content
Submitted about 1 year ago

Sign up form, Mobile First

Théo Brissiaud•160
@brissboss
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Intro component with sign-up form
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This is my sixth project for Frontend Mentor, i want improve my skills in css and js.

I have already some base in css and js but i'm not sure that i use the best practices.

If you have any advice or comments on my work, i would be happy to ear !

Thanks.

Community feedback

  • Sunetra Bhowmick•280
    @kaiser-sbPosted about 1 year ago

    Hey Theo,

    Great job on completing the project! Your design is very good. Don't worry much about best practices in the beginning - overall your approach is good to me. Just some quick things that I wish to add -

    • For CSS reset that you used at first - you may try * selector and put something like -
    * {
margin : 0;
padding : 0;
box-sizing : border-box; /*Removes a lot of sizing issues while working with divs*/
}
    • Your README.md specifies -
      • The email address is not formatted correctly (i.e. a correct email address should have this structure: [email protected]). The message for this error should say "Looks like this is not an email". I think you need to tweak your code a bit to get this. Now you're getting the HTML default message.

    Great job and happy coding!

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord