Sign up form, Mobile First

Community feedback

• 

  Sunetra Bhowmick•280

  @kaiser-sbPosted 12 months ago

  Hey Theo,

  Great job on completing the project! Your design is very good. Don't worry much about best practices in the beginning - overall your approach is good to me. Just some quick things that I wish to add -

  • For CSS reset that you used at first - you may try * selector and put something like -

  * {
  margin : 0;
  padding : 0;
  box-sizing : border-box; /*Removes a lot of sizing issues while working with divs*/
  }
  

  • Your README.md specifies -
    • The email address is not formatted correctly (i.e. a correct email address should have this structure: [email protected]). The message for this error should say "Looks like this is not an email". I think you need to tweak your code a bit to get this. Now you're getting the HTML default message.

  Great job and happy coding!

  Marked as helpful

  1