Brendan• 1,120
@OneManBanned
Posted
Wisslor, well done on a really nice looking solution.
I have some suggestions for you -
- You need to add labels to your form elements. This mdn page explains how to implement them and also the additional benefits of using them.
- You need to add some space at the top and bottom of the page for mobile layouts.
- I would suggest using relative units instead of pixels this page converts them for you.
- Have a look at the validityState api. It will help shorten the code you need to write for checking form inputs.
A really nice looking solution though. Brendan.
Marked as helpful
0
Wisllor PS• 470
@Kevallion
Posted
@OneManBanned
Hi Brendan !
Thank you for taking the time to write me a review. This helps me a lot, and I've learned some new things. I'm going to try to implement your suggestions in my code. Thanks also for sharing some resources with me. The pixel converters look very useful. The validityState API seems very interesting, although I don't know right now how to use it to shorten my code. Maybe in the next project, I will try to use it as much as I can.
Happy coding ! Wisllor.
0
