Sign up form

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi, Bazthos! 👋

  Well done on this challenge! Your solution looks great! 👍 It's nice that you have a hidden h1 on this site (if this is a real website the h1 would exist somewhere else on the page).

  Regarding the RegEx for the email, I recommend searching the RegEx on the internet, and then once you find the one that almost works for you (it's hard to find to exact or "perfect" RegEx right away) then try improving the existing RegEx. I suggest using Regexr to help you understand what the RegEx is doing and at the same time learn RegEx and improve it as best as you can. This way, you ended up learning RegEx and possibly creating your own RegEx.

  Now, some suggestions from me.

  • input with type="submit" is a browser legacy. So, my recommendation is to use button with type="submit" instead. Also, use CSS to uppercase the text. Uppercased text in HTML would more likely be spelled by screen readers.
  • Every input needs a label element. So, I recommend having a sr-only label or even better (in my opinion) is to make the label as a placeholder (you can read this article by CSS Tricks about Form Validation with pure HTML and CSS).

  Keep up the good work! 👍

  Marked as helpful

  1
• 

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  Hi there. You did a good job 😎

  keep improving your programming skills🛠️

  your solution looks great, however, if you want to improve it, you can follow these recommendation:

  ✅ Keep using HTML5 validation attributes (required, minLength, pattern etc).

  ✅ Don’t re-implement stuff HTML5 attributes can do for us (no unnecessary JS).

  ✅ Follow a consistent HTML format. It is important to remain consistent in your HTML style. You can use prettier to help you with that but the goal is to always follow a consistent way you code your markup.

  I hope my feedback will be helpful. You can mark it as useful if so 👍 it is not difficult for you, but I understand that my efforts have been appreciated

  Good luck and fun coding 🤝⌨️

  Marked as helpful

  0

  ---

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @isprutfromua Hey Ivan! It's great that you've been given helpful feedback. However, I don't recommend asking people to mark your comment as helpful. It might create additional pressure on the author of the solution to mark your comment as helpful.

  So, my recommendation is to say something like "I hope you find this helpful" or "I hope my feedback helps", but please avoid asking for your comment to be marked as helpful explicitly.

  Keep in mind that, the main goal of giving feedback is to help people and it is recommended not to expect anything in return. If the solution author marks your feedback as helpful, that's a bonus. 🙂

  P.S. I recommend reading the Frontend Mentor community guidelines to know more about what behaviors should be avoided and encouraged.

  2

  

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  @vanzasetia good point, thanks

  0