Design comparison
Solution retrospective
any feedback is appreciated
Community feedback
- @WebmounsterPosted over 1 year ago
Deberias comprobar los espacios en blanco en los inputs. Valida el formulario aunque solo ponga espacios en los campos. Creo que deberias hacer uso de trim()
Marked as helpful0@vjaimesPosted over 1 year ago@Webmounster Muy buena sugerencia, ni siquiera pensé en esto. gracias por comentar.
0 - @BrandaoAPosted over 1 year ago
Hello. I went through your work and it’s good. But I think there are some few adjustment’s to make it great. When I tried submitting the form empty it popped up all the error messages which is good. But after that I tried inserting my first and last name without resetting the page and the error message continued to stay on, showing first name cannot be empty and my last name cannot be empty meanwhile I had already put in my first name and last name. Same thing happened when I tested the other inputs.
What I’m suggesting here is the error message has to disappear when the information has been filled in correctly and the form is submitted. That is to say try submitting the form first when it’s empty or lacking some information, then try refilling part of the form without resetting the page and intentionally leave out some information so you see if the error messages go out when the right information is put in.
The last part is your email validation. I think you needed to work on it. I tried submitting the form with a partial email for example (brandonlee@gmail.)and the form got submitted. I am new to programming but I believe every email needs to end with something that is either .com or .in or .co etc. so try to take that into consideration when doing your email validation.
Please let me know if my comment was helpful and follow me so you can also comment on my work and we help each other grow. HAPPY CODING🥳
Marked as helpful0@vjaimesPosted over 1 year ago@BrandaoA very good suggestions, thank you for your feedback. I've made some edits to the page so feel free to look at it again when you have the time.
I'll be sure to look at your stuff when I'm able to as well!!
0@BrandaoAPosted over 1 year ago@vjaimes you are welcome my friend. I went through it again and its great.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord