sign up component

Community feedback

• 

  P

  Krishna Vishwakarma•1,390

  @KrishnaVishwakarma1595Posted about 1 year ago

  Hey, @RedMwp

  I have got a few recommendations to improve -

  • You should use <form> tag instead of <div>.

  • When we work with forms it should be mandatory for us to implement the error handling too. Like right now, it doesn't show any error message or something when we either submit and empty form or form with any wrong values for email field. I think you should work on error handling. Show the appropriate message for the empty field or field with wrong value. That's a good practice when working with the forms.

  • When focusing on the input, you can keep the outline border transparent or none. outline: none

  • Instead of giving width: 90% to the button you can keep it 100% & provide the padding like this padding: 1em 2rem for your .form class. So it will look nice.

  Hope this will help you to improve. Keep Mentoring!

  Happy Coding

  Marked as helpful

  2

  ---

  

  RedMwp•870

  @RedMwpPosted about 1 year ago

  @KrishnaVishwakarma1595 thanks your recommendation. I was actually trying to do the email validation using Regex but I got stuck and ended up not doing the whole js thing but i will surely get it done. Thanks again

  1