Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Sign-up Card with JavaScript

@AbdullahSoulat

Desktop design screenshot for the Newsletter sign-up form with success message coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I made a lot of progress with my JavaScript. I think the CSS is also very clean.

What challenges did you encounter, and how did you overcome them?

Managing DOM elements from JavaScript

What specific areas of your project would you like help with?

I would love some feedback on my JavaScript, since I'm quite new to it.

Community feedback

Sarah 540

@AutumnsCode

Posted

Well done!!

There are a few area, I can see improvement.

  • I see a lot of div-elements, to wrap certain area around like the form. Div are non-semantic HTMLs, instead I suggest to wrap the area in <form> element. Also there need to be a <main>-Element.

  • I believe the background -color is the wrong one.

  • Your JS looks fine.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord