Skip to content
Submitted almost 2 years ago

Shortly

Ahmed Wael•210
@JAHMD
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...URL shortening API landing page
  • HTML
  • CSS
  • JS
  • API
3intermediate

Design comparison

SolutionDesign

Solution retrospective

Hey, everyone! Just finished this challenge. I'd appreciate it if you take a look and give me feedback.

Community feedback

  • Adriano•38,040
    @AdrianoEscarabotePosted almost 2 years ago

    Hello Ahmed Wael, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:

    We have to make sure that all the content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    This header tag should not be inside the footer tag as both have different meanings!

    <header class="text-neutral-white font-bold text-lg">Company</header>

    The remainder is excellent.

    I hope it's useful. 👍

    Marked as helpful
    1
    Ahmed Wael•210
    @JAHMDPosted almost 2 years ago

    @AdrianoEscarabote Hey Adriano, thank you so much for your advice. I thought that I can use the header tag to refer to the heading of elements in general. Thank you so much, I fixed it.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord