@oshudev
Posted
Hello there 👋. Good job on completing the challenge!
- You should proper HTML semantic. Instead of using
span
for name, location, and description, you could've useh1
orp
tags. You can learn more about HTML semantics here Semantics - MDN Web Docs Glossary: Definitions of Web-related terms | MDN. - Instead of using
flex
to center text content, try usingtext-align: center
. - It seems that you forgot to add a basic CSS reset. You can learn more about it here A Modern CSS Reset.
- About responsive web design, there are plenty of strategies that you can use to achieve responsiveness, you can learn more here Responsive design - Learn web development | MDN.
I hope you find it useful! 😄
Happy coding!
Marked as helpful
@gmatt20
Posted
Hello @oshudev, glad to see you! I was thinking about doing the proper HTML semantics, too many spans may not be ideal for accessibility. Using text-align: center for the text content also makes sense. I have not encountered what CSS Resets are so I will be learning them, thank you for providing me the resources for it. Thanks again for the resources, especially the responsive web design.