Share Options Popup with CSS Flexbox and Vanilla JavaScript

Community feedback

• 

  P

  Lo-Deck•2,790

  @Lo-DeckPosted about 2 months ago

  Hi well done for this challenge,

  You need to use more semantic tag to improve your HTML, it's better for screen-reader and SEO.

  You use a lot of div you need to use more semantic tag like section or

  <img src="./images/icon-facebook.svg" alt="Facebook" class="social-icon">
  <img src="./images/icon-twitter.svg" alt="Twitter" class="social-icon">
  <img src="./images/icon-pinterest.svg" alt="Pinterest" class="social-icon">
  

  wrap this in ul with li.

  It's better to use em or rem instead of px. FreeCodeCamp. FreeCodeCamp.

  It's easier to start with a mobile-approach FreeCodeCamp.

  Hope to be helpful.

  Marked as helpful

  0

  ---

  

  Yukti Gupta•170

  @yMeerakiPosted about 2 months ago

  @Lo-Deck Thank you for the feedback!

  0