Seventh project (2nd project using grid though)

Community feedback

• 

  Joanna•370

  @JoannaLapaPosted over 2 years ago

  Hi Kawaiiakuma!

  My congratulations on finishing the project. Making projects is the best way of learning!

  Concerning your questions - the perfect source for you is the video of Kevin Powell who did this project and published the video focusing on grid conception. He explains many grid issues. The second source which I highly recommend you to improve your responsiveness skills is a free course from Kevin:

  1. Kevin Powell's solution on GitHub here and his solution with an explanation on youtube here
  2. Kevin Powell's free course Conquering Responsive Layouts here

  Looking at your code:

  1. I noticed that you use often position absolute. Try to avoid it as often as possible - I used it in this project only once if I remember well for a quote image.
  2. I suggest you start with a mobile-first approach (start creating your design from mobile to desktop).

  I guarantee you that if you learn with the 2 sources above you will resolve many responsive problems and everything would be much more clear for you.

  I also recommend some naming convention in your HTML classes - I found BEM convention useful, but there are others too. More about BEM methodology here. A good practice is to name your classes in a way understandable for other people reading your code

  I hope that you will find my feedback helpful, Happy coding! Joanna

  Marked as helpful

  0

  ---

  

  kawaiiakuma•130

  @nirvayathapaPosted over 2 years ago

  @JoannaLapa thanks u very much ma'am for ur advice!

  0