Design comparison
Solution retrospective
When switching to desktop layout, and after setting css grid, the red and orange cards that are together in the central column, had a smaller height than the other two on the sides.
Min or max height on these cards had no effect, they kept staying shorter. What worked was setting the grid row height to the given height, as well as setting the cards' height explicitly, which is what i sticked with.
Is that a correct/good approach? Was there another way of making the cards' height go up to 250px without explicitly setting to this number?
Community feedback
- @brodiewebdtPosted almost 3 years ago
This came out fine. There is no right or wrong way to code a site. Everybody's code will be slightly different. You should make the main section without any other classes. Just create another div inside the main section. If you do that it will clear the issues in the report. I downloaded the AXE DevTools and use that to check accessibility: https://www.deque.com/axe/devtools/
Marked as helpful0@ChrisEskiPosted almost 3 years ago@brodiewebdt Wow that tool seems super useful, just like your comment! Thank you so much!
0@brodiewebdtPosted almost 3 years ago@ChrisEski It is, it will say that there is low contrast in some of the designs, but that will still pass. That is the design not the coding.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord