Services and Products Page

Community feedback

• 

  Adrian H•420

  @AdrianX19Posted almost 3 years ago

  Hi @PitagoraStrike!

  congrats on completing the challenge, really nice job! I've got just some small suggestions:

  • your background colour is a bit off comparing to the designs - although I bet you've noticed already ;)
  • the width of review cards is a bit too small plus the alignment of the first review and the third review is a bit off (the first card should start where the main text starts and the third card should end where the last stars container ends) - you can easily fix this by changing your justify-content for card containers to space-between
  • regarding your accessibility issues, I see in your code that you are using <h4> which seems like you used it just to get smaller font size - heading shouldn't be used for styling, changing it to <h2> and styling in css would be the right approach although in this case I would just use <p>. About the other issues changing divs to semantic tags like <main> and <section> should do or you can just add 'role' attributes to existing divs

  Hope you will find the feedback helpful! Happy coding! :)

  Marked as helpful

  0

  ---

  

  VicDev ☪︎•330

  @ViicDevPosted almost 3 years ago

  @AdrianX19 Thank you for taking the time to comment! I have updated some things, I hope your point of view again.

  A detail in the preview is still seeing the opaque background and the size of the cards but it is already modified

  0