semantinc HTML, CSS, FlexBox and MediaQuerry

Community feedback

• 

  Janelle Schuh•90

  @jschuh23Posted over 2 years ago

  Nice work on your solution Fabricio!! I did notice that the Frontend Mentor report was returning some accessibility and html issues. These should be easy enough to adjust :)

  • For your images, even if they are considered background images they should still have an alt attribute. In this case you would set it as follows: alt="". If you completely omit an alt attribute then a screenreader would read the entire url for the image.

  • The anchor tags that you have listed can probably have the href completely removed to pass the Frontend Mentor test. Meaning don't set them to #. I myself have learned to set blank links to this, but it seems that the FEM test doesn't like those :)

  • I would suggest removing some of the section elements that you have as every section should in turn have a heading element. However, based on your code some sections wouldn't make sense to have a heading. You could probably make do with one section element which includes the entire component.

  Just some suggestions!! Great work!

  Marked as helpful

  0

  ---

  

  Fabrício Lima•80

  @IFafaaPosted over 2 years ago

  Hiii @jschuh23 !! :D thank u!!

  0

  

  Janelle Schuh•90

  @jschuh23Posted over 2 years ago

  @IFafaa Happy to help!!

  0