Semantic HTML5 markup, CSS custom properties, Flexbox, CSS Grid

Community feedback

• 

  Bishal Singh Deo🎮•1,440

  @Bishalsnghd07Posted 9 months ago

  Hi, @Sarkastherin👋

  Congrats for completing this challenge🎉 and you did a tremendous job👏

  Going through your HTML & CSS rather than JS, that you want. Your HTML semantic is good, approach is okay. Just have to work on css basics.

  A one suggestion for you, might it be helpful:

  1)I see in your code, there is a few css foundation errors you given width and height directly in body tag, which is not a best practice, by using height directly in body, you are preventing actual(full) size of your layout, in this case layout of your web page may break, it is negligible in smaller projects, but when you work with larger projects ahead in future, when there is 3 or more components in same web page then it will give a disaster result. I would recommend, Instead of using height you can use min-height. You can use height and width in child div's to maintain your layout responsive. By doing this accessibility and performance of your web page will improved.

  Hope, this small tips will help you ahead in your future too!

  Once again welcome to Frontend Mentor, wishing you a joyful journey ahead and Happy Coding❤️

  Marked as helpful

  0