P
Steven Stroud• 4,160
@Stroudy
Posted
Hey, Great job with this solution you should be proud, A few things I noticed,
- Missing a
<meta>
description tag for SEO purposes, - Setting a height and width attribute to your
<img>
will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image, - Background and foreground colours do not have a sufficient contrast ratio(time.card_date, p.card_content), Low-contrast text is difficult or impossible for many users to read. Check out this Discover and fix low-contrast text with Chrome DevTools,
- Having better
alt=""
descriptions for accessibility is a must check this out Write helpful Alt Text to describe images, - You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
- Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
@media
should also be in relative units likerem
orem
,
I hope you found some of this information helpful, Great solution and you should be proud, Hope you have a good day, Happy Coding!
Marked as helpful
0