Semantic HTML5 markup CSS custom properties Flexbox

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  HEADINGS ⚠️:

  ---

  • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  G-uilhermeF•20

  @G-uilhermeFPosted over 1 year ago

  @0xAbdulKhalid

  Thank you very much for your feedback, which will be of great value to me, I will start to follow these concepts and apply them to my codes.

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="container"> with the main tag and<p class="destaque"> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  Give.description a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1. Give p a margin-top or h1 a margin-bottom value for the space between the text.

  For a responsive content:

  • Replace the width in .content with max-width, increase it value and give it the same padding value for all the sides. max-width:320px padding:16px
  • Give the img a max-width of 100% and border-radius value, the rest are not needed.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  G-uilhermeF•20

  @G-uilhermeFPosted over 1 year ago

  @Hassiai

  Thank you for your feedback. I will start to adopt these concepts in the next concepts. It cost

  0
• 

  Gerald LeCour•170

  @Gerald-LeCourPosted over 1 year ago

  Hey there👋 nice solution!

  If you would like to get rid of the accessibilty and html reports do this:

  1. change your div with the class of "container" into a main element
  2. change your p with the class of "destaque" into an h1 element

  Other than that I think your code looks fine!

  Hopefully this helped get rid of those reports! 👍

  Marked as helpful

  0

  ---

  

  G-uilhermeF•20

  @G-uilhermeFPosted over 1 year ago

  @Gerald-LeCour
  Thank you very much, appreciate your feedback.

  1