Semantic HTML5, CSS nested Flexbox

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @LuamB

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

  Things I like about your solution 🎉

  • Use of semantic HTML elements
  • Clear descriptive CSS classes
  • Use of CSS custom properties

  Things you could improve ✍️

  • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

  • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

  • Try making your solution responsive.

  • Be careful with adding a fixed width and height to elements. If the content inside your element grows you'll run into overflow issues:

  article {
      display: flex;
      flex-direction: column;
      gap: 10px;
      width: 320px;
      height: 497px;
      padding: 16px;
      border-radius: 20px;
      align-content: center;
      background-color: var(--white);
  }
  

  • Try using relative CSS units like rem and em.

  I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  Marked as helpful

  1