Skip to content
Submitted over 1 year ago

Sem Responsivo. :(

João Portes•10
@JoaoLuisPortes
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Sou iniciante e ficaria muito feliz se você deixasse seu feedback para me ajudar a melhorar.

Qualquer crítica é bem vinda. 😉

I'm a beginner and I would be very happy if you leave your feedback to help me improve.

Any criticism is welcome. 😉

Community feedback

  • safdar•130
    @sfdrkPosted over 1 year ago

    make your qr box height as auto .... you are given 520px height , bcs of that text is going out of flow.

    Marked as helpful
    0
  • Vanza Setia•27,775
    @vanzasetiaPosted over 1 year ago

    Hi, João Portes! 👋

    Here are a few suggestions for improvements.

    • Set the document to the English language. The web content is written in English so the value for the lang attribute should be en instead of pt-BR.
    • <img> must have alt attribute.
    • The QR code is not a decorative image. You should add alternative text that describes the purpose of it.
    • Use lowercase for the folder and names—it's the convention.
    • Use <main> landmark element instead of <header> to wrap the card content. <header> is used to wrap navigation links and a logo.
    • Make the <body> element as the flex container of the card to put the card in the middle of the page.

    I hope this helps. Happy coding! 😄

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord