Design comparison
SolutionDesign
Solution retrospective
I just want to know what I can improve on.
Community feedback
- @vanzasetiaPosted over 2 years ago
Hi, Eduardo! 👋
I have a few suggestions for this solution.
- All the car icons are decorative images. So, I would recommend leaving the
alt=""
empty to hide from screenreader users. - I recommend removing the
height: 100%;
from thehtml
andbody
element. If you ever need to specify the height then usemin-height
instead. - Also, it's best to style the
body
element instead of thehtml
element (make thebody
element as the main page or container of the site). - Code your font size in rem, not pixels. This means the text size will be responsive if people want to adjust the size.
Hope this helps.
Marked as helpful2 - All the car icons are decorative images. So, I would recommend leaving the
- @akash-1712Posted over 2 years ago
it help to improve your design
.principal { display: flex;
/* max-width: 768px; */ remove /* max-height: 420px; */ remove width: 73%; margin: auto;
}
- { box-sizing: inherit; }
.columna.activa { /* width: 60%; */ remove }
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord