Second ever time I built something with no tutorial very happy!
Design comparison
Solution retrospective
Okay so this is the second thing Ive ever built with no tutorial and Im very happy with it, only problem is i feel like I styled it all pretty randomly rather than in order and theres probs some styles in there not doing anything also the html feels very cluttered, I have no idea how to set it up for mobile either I havent reached that yet in the course im taking any advice is welcome!
Community feedback
- @AblueremotePosted about 2 years ago
Well done! I am also a beginner and know putting a project together feels great.
Take my advice with a grain of salt, I am trying to learn to teach what I know (it could be wrong)
- I notice your .card class has a height element. You may not need this -Your elements inside can define your height for you ie. your <img has a height of 400px so it will default to that height.
If you right click and inspect your browser, I go through my elements to see what attributes is doing what exactly. You can try this to see what elements are not needed. Basically cleaning your code some.
The .card height is one i found. There is another in the img class. Hope this helps
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord