SCSS(FLOCSS x BEM)

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey, great work on this one. The layout both in desktop and mobile is fine I guess, but resizing is really issue since the layout does not scale that well.

  Suggestions would be:

  • Remove the padding on the body tag. This creates that white space in the sides which is not good.

  • Remove the width: 1300px on the .p-card selector, this limits the element's width at that point, thus creating that empty space on the right.

  • Resizing, does not help your layout in this very much, since you declared multiple fixed widths on the elements. Try adjusting those using % to scale with the resizing .

  • Reaching the mobile state, there is this huge white space around it which is not really ideal. Remove that width: 375px on the .p-card . This will stretch your layout to fit all the remaining spaces of the viewport, which is always the case in mobile layout. Remove as well the height on the .p-card. Allow the element to give the dimension it needs in the mobile state.

  If you need more help, just drop it here okay. @introvert-rgb already mentioned the solution, try googling that one, it is really awesome. Still, good job on this^

  0

  ---

  

  UpMountains•30

  @JavateaboyPosted over 3 years ago

  @pikamart Thanks for the advice. I'll try it.

  0
• 

  Anup Singh•130

  @introvert-rgbPosted over 3 years ago

  use background blend property

  0

  ---

  

  UpMountains•30

  @JavateaboyPosted over 3 years ago

  @introvert-rgb Thanks for the advice.

  0