Skip to content
Submitted over 4 years ago

SCSS Practice mainly, JS for form validation

Diarrah•3,418
@Diarrah
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Base Apparel coming soon page
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Please help me with my SCSS if you know it. Also, I think I have a problem with the background covering the whole height of the left side.

Community feedback

  • Ynnk•170
    @HYannickPosted over 4 years ago

    Hi! Nice shot! I like the transition on the error/valid field.

    For your issue, I wondered why you didn't use the display: flex on the body?

    It seems here but not applied since left and right side have their own width and the right part a position: fixed.

    Maybe you could remove the widths and replace them with flex-basis or flex property since the purpose of flexbox is to have 'flexible' content inside. With this, the fixed position of the right side removed and a body with a min-height: 100vh the background will take the whole height.

    Hope that helps :)!

    1
    Diarrah•3,418
    @DiarrahPosted over 4 years ago

    @HYannick I was experimenting with your suggestions & a simple min-height: 100vh on the body worked.

    Thanks!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord