SCSS

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted almost 3 years ago

  Hey, that's a great solution! It looks very neat on all screen sizes.

  There's a few bits you could perhaps improve on:

  1. Insure logo alt-text (in header and footer sections): instead of "logo", "Insure" would be a better alt, I believe (more on this topic here).

  2. Footer section, socials: this div could actually be a ul with links wrapped in li. Since these links lack a text description, you could use aria-labels!

  3. Perhaps the title of the footer link groups could be some sort of heading instead of p tags.

  4. Your hero section doesn't belong in any landmark. It should go into either the header or main (probably putting it in main is a better option).

  5. You're using multiple h1 headings. There should be only one for the main title of the page, then decrease the levels by one ^^ (great explanation on this topic here).

  These are just minor things to be honest, overall I think you did awesome. I'll definitely look at your solution when I work on this challenge in the future ^^

  Marked as helpful

  1