scss, mobile first etc.

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Good job in this challenge. Viewing the solution, I think you should consider the following as well…

  • Use semantic tags, for HTML structures, refer it with this one Semantics
  • Instead of nav, wrap this line <nav class="navigation"> with header tag
  • Wrap the 4 section with main tag to organize the code
  • Increase the breakpoints or add another one for Tablet view, the sections tend to compress each other between 899px - 377px width
  • Simplify the margin in the p, img and h3 into margin: 0 auto; and padding into padding: 1rem; for mobile view
  • Add font-size: 35px; in the heading of each sections
  • In the .footer .newsletter .newsletter_input rule sets, adjust the flexbox direction into flex-direction: row;. Remove margin-left: auto;andmargin-right: auto;, adjust intomargin: 0 auto;`
  • Adjust the logo size into width: 195px; in the .footer .about-and-contact img and .navigation_logo img rule set

  Above all, Well done! Keep it going!

  Marked as helpful

  0

  ---

  

  VINIT CHURI•160

  @vinit-churiPosted almost 3 years ago

  @RioCantre Thanks for such detailed feedback

  0