SCSS, Media Query Function

Community feedback

• 

  Marvin Baga•310

  @mjbagaPosted over 2 years ago

  Hi @topspinppy. Good job on the challenge.

  I've checked your code and have a few feedback:

  • I would recommend to separate your media queries in big group chunks, instead of repeating the media query includes on a few declaration blocks. It's something I also used to do, but when you check your compiled styles.css, you'll see the same media queries were repeated like 16 times on the file. It wouldn't matter much on very small projects but quite significant or large ones, even saving a few kilobytes.
  • You can check out mobile-first development. It helped me out a lot in coding for responsive design. Basically it's coding for mobile first and adding media queries as you go up in screen size. So you'll be using your min-width mixins instead of max-width.

  That's it. Hope this helps! Happy coding!

  0