Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

SCSS, JS Vanilla, FETCH API, any advices is welcome as always! Thanks

Radek 230

@RadeQu

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

Ahmed Bayoumi 6,740

@Bayoumi-dev

Posted

Hey Radek, It looks great... You just have an accessibility issue you need to fix.

  • Buttons must have discernible text, Don't leave the alt attribute empty.
<button class="changeAdvBtn">
   <img src="./images/icon-dice.svg" alt="Advice generator">
</button>

Or Set the attribute aria-label to describe this button. like this:

<button class="changeAdvBtn" aria-label="Advice generator">
   <img src="./images/icon-dice.svg" alt="">
</button>

Keep coding👍

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord