Design comparison
SolutionDesign
Solution retrospective
Feedback welcome. the more the better. thanks
Community feedback
- @mattstuddertPosted almost 5 years ago
Nice work on this, Ben! Your solution looks really good. I've got a couple of small suggestions, but nothing major:
- I'd use a
form
element instead of adiv
with a "form" class for the email input. You can then listen out for thesubmit
event on the form, as opposed to aclick
on thebutton
. - I'd also recommend adding anchor tags around the social icons and making them accessible. As you'd expect these to be clickable links if this were a real landing page.
Keep up the great work! 👍
0 - I'd use a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord