SCSS grid and flexbox layout

Community feedback

• 

  Marvin Baga•310

  @mjbagaPosted over 2 years ago

  Hi Ali. Nice work on the challenge.

  Just some feedback:

  • Was already pointed out on the social media icons. This usually happens when height and width doesn't match. You can try setting an explicit height and width, maybe in pixels. Or you can define just the width or height and use aspect-ratio: 1/1;
  • I'm on a larger screen and the social media icons are cut off, almost by half and can't scroll down. Maybe doesn't need the overflow: hidden on body.
  • On your button, maybe you can add a small transition effect, transition: color 300ms ease-in;. These are micro-interactions that improve user experience.

  Hope this helps! Happy coding!

  Marked as helpful

  0

  ---

  

  Ali Ahmed•680

  @Dany-GitHubPosted over 2 years ago

  @mjbaga Thanks so much for the feedback i modified my solution i think its way better now ❤

  1
• 

  Divine Obeten•2,415

  @Deevyn9Posted over 2 years ago

  Wow, i almost couldn’t differentiate the one you made from the original, there’s a very minor issue though, the social media icons have an oval border, you can make it fully round by setting the border radius to 50%

  Marked as helpful

  0

  ---

  

  Ali Ahmed•680

  @Dany-GitHubPosted over 2 years ago

  @Deevyn9 i did that but looks as shown its kinda weird i will try to make it better , Thanks for the feedback ❤

  0

  

  Divine Obeten•2,415

  @Deevyn9Posted over 2 years ago

  @Wa7dany you’re welcome

  0