SCSS grid and flexbox layout

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted over 2 years ago

  Heyo,

  It looks really good, well done! There's a few small things you could look into:

  1. Your "heading__header-text" div isn't centered in mobile/tablet view before the breakpoint switches.

  2. Your social links in the footer section are missing aria-labels. All links that have no text content should have these.

  3. When writing alt texts, you shouldn't include words like image, icon, logo, illustration, etc. By using an <img> element you make it obvious what they are. When you feel like you can't come up with any meaningful text description of an image, it might mean that the image is decorative only and in this case leaving the alt text just empty is the best solution (in this case screen readers will skip announcing it, but to be sure you can also add an aria-hidden="true" to them). For logo images, it's best to just spell out the brand itself, in this case this would be "Huddle."

  Good luck ^^

  Marked as helpful

  0

  ---

  

  Ali Ahmed•680

  @Dany-GitHubPosted over 2 years ago

  @FluffyKas Thanks for your valuable suggestions i will modify it ❤️

  0