Scss Grid

Community feedback

• 

  Arne•1,110

  @DudeldupsPosted over 1 year ago

  Hello 👋🏻

  The design looks good, for my liking you could set the media queries a tiny bit higher. It looks a bit wonky right when the media query kicks in.

  Also here are some tips:

  • This is a very good use case for the figure element, although you mixed up the parent-child relationship with the figcaption. The figcaption is supposed to be the child of the figure 🙂

  • In your HTML, always have the heading elements in descending order. You don't really have something in this challenge that you can use as an h1 so here it's missing for once, but the next heading in order would be an h2

  • There's also no need to wrap the heading and the paragraph in a separate div. You can just style the element with the same CSS rules.

  • Every page should have a main element. You could just exchange the div that is your .grid-container with the main element.

  • Variables in HTML and CSS are usually written in 'kebap-case'. The words themselves are all lowercase.

  I hope this was helpful, happy coding! 👾

  Marked as helpful

  0

  ---

  

  Priskin Zsuzsanna•320

  @PriskinZsuzsannaPosted over 1 year ago

  @Dudeldups Thank you so much!!! I will try all of your suggestions. I'm tring to learn about semantic html and accessibility, so your comments were extreamly helpful!

  0