scss: flexbox, @media, ...

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Dušan! 👋

  Nice to see you complete another challenge, again! 👍 Good job on this one! 🙌

  I only suggest allowing the backgrounds of the hero and the footer to fill up the entire area of the screen (even when the screen width increases) so that there's is no empty white space to the sides of those sections on extra-large screens. 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Dušan•210

  @osmonohPosted almost 4 years ago

  @ApplePieGiraffe cheers

  1
• 

  Web Frog•1,840

  @MasterDev333Posted almost 4 years ago

  Great work Dusan. Everything is well organized and fully responsive. It would be better if you add more transition effects. Look forward to seeing other solutions from you. Happy coding~ :)

  1

  ---

  

  Dušan•210

  @osmonohPosted almost 4 years ago

  @MasterDev333 thank you for the feedback

  1
• 

  Abhik•4,840

  @abhik-bPosted almost 4 years ago

  Hi Dusan ,Good job on this solution

  • It seems great on large screens
  • however on hovering try for free font-size reduces and don't know why but it feels a bit jarring
  • it is very responsive looks good on mobile screens

  Keep it up 💯

  1

  ---

  

  Dušan•210

  @osmonohPosted almost 4 years ago

  @abhik-b Thanks a lot for your feedback. That hover effect you describe doesn't reduce the font-size and it's not jarring.. apart from color:lighten() there is also transform:scale(0.98) with a very short transition:0.1s.. I believe that is what you perceived as jarring and font-size reducing

  1

  

  Abhik•4,840

  @abhik-bPosted almost 4 years ago

  @osmonoh Sorry my bad , anyway good job 💯

  1