SCSS, Flexbox and Grid

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Hey Ben, great work on this challenge! Your solution scales down nicely to mobile and looks really good. My only small recommendation would be to use a ul instead of a p for the "Why Us" section.

  Keep it up! 🙌

  0

  ---

  

  bwhitney2439•545

  @bwhitney2439Posted almost 5 years ago

  @mattstuddert thanks Matt. Can I ask why ul over p?

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  @bwhitney2439 sure! Based on the design you can see that the items are a vertical list of features/benefits. So a list element would make sense, especially if you consider screen reader users. With the p tag the content will be read out in one go, whereas with a list it will specify each new list item and read it out with more context for the user.

  0

  

  bwhitney2439•545

  @bwhitney2439Posted almost 5 years ago

  @mattstuddert Thanks Matt. I'll make the changes.

  0