scss

Community feedback

• 

  Finney•3,030

  @Finney06Posted over 1 year ago

  Hello there 👋. Good job on completing the challenge !

  Here are some suggestions regarding your code that may be of interest to you.

  HTML 🏷️:

  To clear the Accessibility report:

  • Wrap the page's whole main content in the <main> tag.

  • Use HTML5 semantic elements such as <header>, <nav>, <main>, <aside>, and <footer> to define these sections.

  I hope you find it helpful!😏 Above all, the solution you submitted is 👌. 🎉Happy coding!

  0
• 

  Loai Esam•670

  @LoaiEsam37Posted over 1 year ago

  to make the perfume word become like the design you can use letter-spacing property in css to increase the space between letters in the word also this is an extra tip you can use line-height property to increase or decrease the spacing between lines

  happy coding

  0
• 

  Loai Esam•670

  @LoaiEsam37Posted over 1 year ago

  add role main to your <div class="container"> tag like this <div class="container" role="main"> or you can just do it like this <main class="container"> and the idea here is to make it more easier for screen readers to know where is the main content and you can also use something like <nav> , <footer> and <sidebar> tags for the same reason. also here:

        <p>perfume</p>
        <h1>Gabrielle Essence Eau De Parfum</h1>
  

  you have to make it like this

        <h1>perfume</h1>
        <p>Gabrielle Essence Eau De Parfum</p>
  

  because the page have to start with h1 and then you can change the font-size from css

  hope you find this helpful

  0

  ---

  

  Pipow•500

  @PipouwPieuwPosted over 1 year ago

  @LoaiEsam37 Hello!

  I don't think the page has to start with a <h1> necessarily. You can't skip a heading level, i.e. having a <h2> before a <h1>, but having a <p> before should be fine. If in doubt, a <span> could be used instead.

  In this example I think Gabrielle Essence Eau De Parfum is a way more accurate title than perfume. :)

  0

  

  Loai Esam•670

  @LoaiEsam37Posted over 1 year ago

  @PipouwPieuw Okay, I think you have point there, Thank you :)

  0