SCSS - BEM - Mobile First - Flex & Grid - Vanilla JS

Community feedback

• 

  Gavin•180

  @DesignAssemblyPosted over 3 years ago

  Hi Rafet

  Great work on the build. a couple of things I'd like to point out that may be of help. When a user clicks the selected pledge - maybe highlight that pledge already in the modal, with the cursor in the input box ready for the user to make his/her pledge. This way the user does not have to do the same action twice - just a little UX feedback.

  Would also keep the modal fixed and not scroll with the whole container- but rather scroll the content inside the container - just personal preference I guess.

  Once a user exits the modal then goes back with a different pledge, the previous pledge is still highlighted - maybe think of clearing out all pledges on close of modal and on close of thank you modal.

  But from a javascript point of view - man that is some beautiful code!!!!! I'm nowhere on that level as I come from a UX background and currently learning my Javascript. That blew my mind. really something I will bookmark for myself to learn from.

  I'm still trying to get my head around passing functions into other functions. - lol But well done !!!!!

  1

  ---

  

  rafet•925

  @rafetbasturkPosted over 3 years ago

  @DesignAssembly

  Hello Gavin! 👋

  Thanks for your UX feedback and suggestions. I have updated my code accordingly. 👍 Please check again whether or not it is okay?

  And also thanks for your praise about the JS code. ☺️ It has been around a year since I started learning JS. I am still struggling with the advanced concepts.

  Happy coding! 😊

  0
• 

  Sofia Skrbic•125

  @sofskrbicPosted over 3 years ago

  Hello, Rafet! 👋

  The solution you provided looks great! The responsiveness works good. The only thing I would suggest changing is that only one stand is selected at the time. Looks like you're using some sort of checkboxes instead of radio buttons.

  Overall, I think you've done an amazing job! Happy codding 😄

  1

  ---

  

  rafet•925

  @rafetbasturkPosted over 3 years ago

  @sofskrbic

  Hello, Sofia! 👋

  Yes, I used ticks instead of radio buttons. Actually, I don't know how but, I saw them as ticks in design files. 😄

  Thanks for your suggestion. 👍 I will fix the selected stands as you suggested asap.

  Happy coding to you, also! 😀

  1
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hi, rafet! 👋

  I hadn't noticed you submitted another solution! 😀 Nice job on this challenge! 👏 Overall, the page looks pretty good and responds and works well! 👏

  I only suggest making sure that users can't pledge less than the minimum amount for each product. 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  rafet•925

  @rafetbasturkPosted over 3 years ago

  @ApplePieGiraffe

  Hi! 👋🏻

  Ohh, I haven't thought of the minimum pledge amount 🤭 I will fix it asap. Thanks for reminding me.

  Happy coding to you, too! 🙂

  0