Scroll animations with scss

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Isy! 👋

  Nice job on this challenge! 👏 Your solution looks good and I think the animations that you added to the page are very nice! 👍

  I'd like to suggest,

  • Making sure the header navigation doesn't jump to the middle of the screen in the under 1200px.
  • Darkening the background of the mobile navigation a bit more so that the navigation links are more readable.
  • Adding text-align: center to the text content under the "Share Your Bookmarks" section in the mobile layout (as in the original design).
  • You have a few issues listed in your solution report. I suggest looking into those and trying to clear a few of them up to make your markup more semantic and your solution more accessible! 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Isy•215

  @isy-createsPosted almost 4 years ago

  Hey ApplePieGiraffe 👋 (This name is so sweet! 😍)

  Thank you so much for the time spend reviewing my solution. I updated my Landingpage and fixed a few more errors I found along the way. So you helped me alot. I appreciate it. 😊

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  @css-animation

  Haha, thanks, Isy! 😊 I just took another look at your solution, and the changes you've made look great! 👍 Everything's pretty good, now; nice work! 🙌

  1

  

  Isy•215

  @isy-createsPosted almost 4 years ago

  Thank you! 😊 I even found a solution to one of the accessibility error I had: "Anchor element found with a valid href attribute, but no link content has been supplied." You mentioned the solution using <title> on the same project made by another person. Now I'm error free. 😁 You are an incredibly helpful person. 🙏

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  @css-animation

  I was just going to suggest that, but I wasn't completely sure if it was the same issue. 😄 But glad you found it and got it solved, then! 🙂

  0