Scoot multi-page layout | HTML | SCSS | JS

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello KULEK,

  Your solution looks great. I have some suggestions regarding your solution, if you don't mind:

  • It's recommended to avoid creating duplicate content (eg: duplicate navigation). You can style the same navigation in mobile and desktop differently using media queries. Practice like this can result in a poor user experience, when a visitor finds substantially the same content repeated within a set of search results.

  • I suggest to put the nav links within an unordered list structure so that a screen reader will read out how many things are in the list to give visually impaired users the most information possible about the contents of the navigation.

  • To ensure that the landmarks are unique, you should add aria-label=”secondary “ or aria-label=”footer” to <nav> in the <footer>. A brief description of the purpose of the navigation, omitting the term "navigation", as the screen reader will read both the role and the contents of the label.

  Thenavelement in the header could use an aria-label="primary" or aria-label=”main” attribute on it. The reason for this is that, you should add the aria-label for a nav element if you are using the nav more than once on the page.you can read more in MDN

  Aside these, excellent work! Hopefully this feedback helps.

  Marked as helpful

  0