Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

scane qr code

mohamed 50

@inconnux

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


i find default in placing div container in the center

Community feedback

Hassia Issah 50,650

@Hassiai

Posted

Replace <div class="idiv"> with the main tag <main> to fix the accessibility issues. click here for more on web-accessibility and semantic html

This challenge does not require a box-shadow.

The body has a wrong background-color. Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

To center .container on the page using flexbox, add min-height: 100vh to .idiv.

Give .container a padding values for all the sides instead of a height value, this will prevent the content from overflowing. `padding:15px'. Give the img a max-width of 100% instead of a width and height value. For a responsive content, replace the width in .container with max-width value.

Give h1 and p the same font-size of 15px and the same margin-left, margin-right and margin-top values. Give p a margin-bottom value. Give p opacity of 0.5 for the faded color.

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

0

mohamed 50

@inconnux

Posted

@Hassiai thinks for your remarks i will try to modify it

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord