SCAN CODE CARD

Community feedback

• 

  Malik Safwan•60

  @ssafwannPosted over 2 years ago

  Not bad, but there are some things you can work on. The main problem is how you positioned the QR code component, I see that you used the following CSS property transform: translate(800px,190px); You shouldn't do this because it placed the container in a weird position. Instead, if you want to center something in the middle of the screen use margin: 0 auto; and set a max-width; I don't know how to explain it that well so you may visit this URL for more information: http://web.simmons.edu/~grovesd/comm244/notes/week6/center. If you use this method of positioning the container in the center, you will find that you have to write fewer media queries, because the container will always be positioned in the center no matter the size of the device. But you may have some problems if you set a max-width too large, so you may need to change that in your media query.

  0

  ---

  

  Kallakuri Sahitya•100

  @Sahitya2006Posted over 2 years ago

  @ssafwann Thank you for the suggestion.

  0