Skip to content
Submitted 11 months ago

Sass/Scss

Szeri•60
@Szeri323
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hi there,

if you have some advices please let me know. :)

Community feedback

  • Daniel 🛸•44,310
    @danielmrz-devPosted 11 months ago

    Hello @Szeri323!

    Your solution looks great!

    I have just one suggestion:

    • Since you used Sass, you don't need to use root to set your variables. You can set them like this:
    Example:
$color-white: #fff;
$font-poppins: 'Poppins', sans-serif;

    and then use background-color: $color-white;.

    I hope it helps!

    And Happy New Year!

    Marked as helpful
    1
    Szeri•60
    @Szeri323Posted 11 months ago

    Hi @danielmrz-dev,

    Thank you for the advice, I changed the code and now it is better.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord