sass/bem/flexbox landing page

Community feedback

• 

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted about 3 years ago

  Hey, I think your solution is pretty great! You nailed most of the design requirements! I just have a few things to say;

  1. You missed the social media icons in the footer of your solution. I looked at your code to see what the problem could be and I found out that you missed the "." command that enables you to get out of your current directory when you were placing the images in the HTML file. I think you were using live server, it usually corrects this but when you open the file, the changes are reverted.
  2. I had problems with the responsiveness I think it's better to use the max-width attribute instead of the min-width attribute (it makes it a bit easier) I haven't yet learned sass but your code sure did make me feel like it so I think I know what to learn this week😉 Apart from that, I really think it is a great solution! I also appreciate the time you gave to develop this solution! Kudos! Keep on coding!

  Marked as helpful

  0

  ---

  

  Clau•155

  @clause5Posted about 3 years ago

  @tesla-ambassador, thank you so much for your time and advise. You're completely right, I can see the missing points on the image paths. I'm going to fix it right now. Regarding the media queries I always have trouble choosing them, since the design is for two sizes, some times I think I should add something in the middle like iPad size. Thank you so much! Happy Coding!

  0

  

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted about 3 years ago

  @clause5 You are very welcome! Regarding the media queries, I normally just keep on resizing the screen and when I see things are going out of place, I fix them and that way, when I reach the phone size, it's normally smooth. But I usually do 4 screen sizes at most but normally it's just 3. Happy coding to you too!

  Marked as helpful

  0