Design comparison
Solution retrospective
I think i did something here. Feedback and corrections welcome
Community feedback
- @FluffyKasPosted about 3 years ago
Hiya, your solution looks good! There's a few things to correct though!
-
Email validation: it lets me submit an incorrect email format, it only warns me if it's empty or if it's less than 8 chars.
-
Your social links have aria-hidden on them. I don't think this is what you're looking for here, as you don't want to deny access to certain features from visually impaired users. Aria-labels would me more correct here, so they can still see that there are links leading to social media sites, and aria-labels would give them description of these links!
Well done on completing this challenge though, it's a big job :)
Marked as helpful1@imonaarPosted about 3 years ago@FluffyKas Thank you for having a look. Letme correct and get back to you
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord