sass. parcel, netlify

Community feedback

• 

  Muhammad Shajjar•1,100

  @muhammadshajjarPosted about 3 years ago

  Hi kevin, Welldone you did a great job, it response well.

  I have some suggestions for you

  • the a tag that wraps the img should have aria-label="home- insure" . This way, users will know where this link would take them. this has to be applied to both the header and footer logos. I think the word insure is more likely for alt, rather than logo
  • The how we work should be a link, in my opinion, using a tag and not a button. Use the button if it will act as a control for something. But on this, it is treated as a link, go for a tag.
  • Your logo image should not be in nav.
  • For any decorative images, like in this case the icons in your cards , you should leave the alt="" and add aria-hidden=" true" or role=" presentation" to make sure that all screen readers will ignore those icons.

  Marked as helpful

  1

  ---

  

  kevin•415

  @imonaarPosted about 3 years ago

  @muhammadshajjar Thank you. I have implemented all your suggestions. On the logo image not being in the nav, implementing from my next projects

  0
• Account deleted

  Hi,

  I honestly think at 1440px it looks, but there's problems as your switch to smaller screen sizes;

  • The photo at the top and the text on the side of it overlaps as the screen size decreases, and this goes on until you reach the mobile view. Not sure what you used but with flex-box it surely wouldn't be happening.

  • The whole page loses padding so everything is just on the edges when you down-size.

  • Mobile view looks ok, and give the mobile menu should cover the whole screen, so that also needs fixing 'cause it's currently not.

  Keep coding👍.

  Marked as helpful

  0

  ---

  

  kevin•415

  @imonaarPosted about 3 years ago

  @thulanigamtee @arshad81 thank you for your feedbacks. I find that progressively resizing towards mobile view is what makes it look awful. probably because is positioned that hero image absolutely in desktop view, working on making itbetter

  0
• 

  Arshad Gilani•15

  @arshad81Posted about 3 years ago

  Hey Kevin, you did a great work but you messed up the Side Nav Bar for smaller screens. That's the only thing you did wrong. Amazing work keep it up

  Marked as helpful

  0