Design comparison
Solution retrospective
Any feedback is welcome!
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
BACKGROUND iMAGE 📸:
- The
background
has not been properly set yet for Desktop devices, So let me explain How you can easily apply thebackground color
along with thesvg
they provided.
- Add the following style rule to your css, and then experience the changes
body { background: url(./images/pattern-background-desktop.svg), #E1E9Ff; background-repeat: no-repeat, no-repeat; background-size: contain; }
- Tip, Don't forget to generate a new screenshot after editing the
css
file
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@PriskinZsuzsannaPosted over 1 year ago@0xAbdulKhalid
Hi Abdul!
Thank You!!! You are absolutely helpful. I always struggle with svg-s, svg backgrounds, images with svg-s. Your solution is really great. Thanks again!
0 - @daniel-web-developerPosted over 1 year ago
Nice work! I liked the animations.
I've noticed something, though. The animations only work when the cursor starts hovering the element, but there's no "out" animation; it just comes back to the normal state as soon as you "hover off".
To fix this, you need to remove
transition: all 0.3s ease-in-out
from the:hover
and add it either to the normal class or, in the case of the buttons, add a class to the button with the propertytransition: all 0.3s ease-in-out
, or maybe just addtransition: all 0.3s ease-in-out
to all buttons.Marked as helpful0@PriskinZsuzsannaPosted over 1 year ago@daniel-web-developer
Hi Daniel!
Thank You so much!!! You are absolutely right. I will move the transition to the buttons. Thanks for spotting it, and writing to me!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord