Sass, js(vanilla), BEM

Community feedback

• 

  Amon•2,560

  @A-amonPosted about 3 years ago

  Hello! It's an amazing work, really! 😲

  But here are some suggestions:

  • Place your .container inside a main landmark tag.
  • Instead of so many arrays (dailyCurrent, dailyPrevious, weeklyCurrent, ...), you can use array to store objects. For example:

  const dailyData = [
    {
      current: 0,
      previous:0
    },
    ...
  ]
  

  • You can try using template for elements such as those cards 😉. (So the JS wouldn't be cluttered with createElement). Although you will still need to querySelector each class inside to set the values. 😂
  • Instead of card0, card1, ..., why not use an array to store them? 🤔 This way, your displayCards() and removeCards() lines of code will be much lesser and less repetition.

  2
• 

  Candela Bramucci•680

  @bramuccciPosted about 3 years ago

  Wow, this is really incredible! The design is indistinguible from the original and the responsive is magnificent, you use the grid layout so well. I really like this so much, please keep going 💖. And for the dots... maybe you can put a mini menu who cover the card with fake options? You can use addEvenListener click and mouseover.

  1

  ---

  

  Felix Criollo•575

  @FelixCriolloPosted about 3 years ago

  @Liltanie Thank you. I used PixelParallel, it is a google extension, to make the design as similar as possible

  1