Sass, Javascript

Community feedback

• 

  Ahmed Faisal•5,095

  @afrusselPosted about 3 years ago

  Good work. Use main after body tag Use rem instead of px for font size

  Marked as helpful

  1

  ---

  

  Ruben Abreu•70

  @RaCode75Posted about 3 years ago

  @afrussel You're right. Thx.

  0
• 

  Džiugas Balčiūnas•190

  @DziugisLTPosted about 3 years ago

  Suggest not to use a border, because it moves everything when you add a border on hover or focus. Use box-shadow: 0 0 0 {size of border you want} {color};

  Marked as helpful

  0
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 3 years ago

  • the layout for display shifts when calculating
  • the calculations are not correct, sometimes zero number of people is giving positive values . First enter 1 in the number of people and a bill of 100 - do some calculations then change the number of people to zero or just click the input box - it will revert to zero. Then do some calculations. It does the same also with a zero bill and zero number of people.
  • input elements are missing labels

  Marked as helpful

  0

  ---

  

  Ruben Abreu•70

  @RaCode75Posted about 3 years ago

  @ChamuMutezva you're right. I must correct it. Thx.

  0
• 

  Conrad•950

  @ConradMcGrifterPosted about 3 years ago

  I would use a css class that gets toggled with JS to display the selected tip % styles instead of using the :focus pseudo class. The problem with :focus is that if I click off the button it removes the styles and I no longer know which tip % is being used

  other than that it looks really good. nice work!

  Marked as helpful

  0

  ---

  

  Ruben Abreu•70

  @RaCode75Posted about 3 years ago

  @ConradMcGrifter Thx.

  0