SASS, HTML5, CSS AND JAVASCRIPT

Community feedback

• 

  Faris P•2,810

  @FarisPalayiPosted over 3 years ago

  Things you can improve:

  • change the <p> tags to <a> tags on the navigation menu, and also change the social media icons to <a> tags, since those all are links to other webpages.
  • change the div .nav to <nav> element. Learn more about semantics: link 1, link 2
  • And also try to add :focus state styles if you can, because it can help keyboard users tremendously.

  That's all from me.

  As your first challenge, I think you have done an excellent job. The site overall looks visually very pleasing. Have fun coding ✨

  Marked as helpful

  0

  ---

  

  Michael•430

  @mikester380Posted over 3 years ago

  @FarisPalayi Thanks alot for your feedback. I used paragraphs instead of anchor tags as this was just a design and not a full fledged website. I'll make sure I change them to anchor tags as soon as possible.

  1

  

  Faris P•2,810

  @FarisPalayiPosted over 3 years ago

  @mikester380 No problem, glad I could help.

  And hey, no pressure. You are right, it is not a full-fledged website, but I think it's best to follow the best practices so that you can make it a habit, and when you make a real website, you don't need to think a lot about it. But don't feel pressured to do so😀👍

  0

  

  Michael•430

  @mikester380Posted over 3 years ago

  @FarisPalayi thanks bro.

  1