SASS, Flexbox

Community feedback

• 

  patil sahil•440

  @Patilsahil821Posted over 2 years ago

  well done , just add two missed background image and best of luck for your next projects....

  Marked as helpful

  1

  ---

  

  AditNovadianto•1,040

  @AditNovadiantoPosted over 2 years ago

  @Patilsahil821 thankyou so much for your advice!!!

  0
• 

  Bhremada Fevreano•1,395

  @boedegoatPosted over 2 years ago

  Well done @AditNovadianto

  One thing to note is you should add <main> tag as the container to fix your accessibility issue

  Keep practicing and happy coding

  Marked as helpful

  1

  ---

  

  AditNovadianto•1,040

  @AditNovadiantoPosted over 2 years ago

  @boedegoat thankyou for your advice Bhremada Fevreano!!!

  0
• 

  Martin Kamír•490

  @Martin-K-KamirPosted over 2 years ago

  Nice work @AditNovadianto!

  Few things to point out.

  1. The FAQ content disappears at viewport 820px and then comes back at. I could not find why in the devtools. I would need more time to look into it.

  2. When you get to 423px viewport the whole content goes off the screen. Not very friendly for mobile users. On that container you set width to 900px. Would be better if you changed it to max-width and added media query at max-width 500px changed the width value for something smaller like 300px.

  3. When you get to phone screen sizes the FAQ content is not very centered since you set margin-left: 100px. It is not good practice to center content with margins. Use flex instead.

  Anyway i think the solution is good just needs bit work. Wish you best luck in next projects :)

  0