patil sahil• 440
@Patilsahil821
Posted
well done , just add two missed background image and best of luck for your next projects....
Marked as helpful
1
AditNovadianto• 1,040
@AditNovadianto
Posted
@Patilsahil821 thankyou so much for your advice!!!
0
Design comparison
Solution retrospective
I will be happy to hear any feedback and suggestion!!!
Community feedback
Bhremada Fevreano• 1,395
@boedegoat
Posted
Well done @AditNovadianto
One thing to note is you should add <main> tag as the container to fix your accessibility issue
Keep practicing and happy coding
Marked as helpful
1
AditNovadianto• 1,040
@AditNovadianto
Posted
@boedegoat thankyou for your advice Bhremada Fevreano!!!
0
Martin Kamír• 490
@Martin-K-Kamir
Posted
Nice work @AditNovadianto!
Few things to point out.
-
The FAQ content disappears at viewport 820px and then comes back at. I could not find why in the devtools. I would need more time to look into it.
-
When you get to 423px viewport the whole content goes off the screen. Not very friendly for mobile users. On that container you set width to 900px. Would be better if you changed it to max-width and added media query at max-width 500px changed the width value for something smaller like 300px.
-
When you get to phone screen sizes the FAQ content is not very centered since you set margin-left: 100px. It is not good practice to center content with margins. Use flex instead.
Anyway i think the solution is good just needs bit work. Wish you best luck in next projects :)
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord