Skip to content
Submitted over 3 years ago

Sass, Flexbox

John Ademoye•235
@Moyo75
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Interactive pricing component
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

I would like feedback particularly on my Javascript and (S)CSS. I feel like I could make some of the CSS more reusable. And given this level, how do you think I can improve myself further and possibly get a job? Which projects would you recommend, here or somewhere else? I'm really keen on getting better and not relapsing. Thank you very much...

Community feedback

  • Robert Mion•0
    @rmionPosted over 3 years ago

    Let's start with a smile: great job completing this challenge. I learned some interesting things reviewing your code.

    I spotted one possible oversight in your code: when the toggle button is checked, you present a price that seems to offer a 75% discount, not a 25% discount. You should multiply the value by 0.75, not 0.25.

    Again, great work!

    0
    John Ademoye•235
    @Moyo75Posted over 3 years ago

    @rmion Oh. I guess I paid so much attention to the coding that I forgot the math. I'll fix it asap. Thanks!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord