Skip to content
Submitted over 3 years ago

SASS, Flexbox, JavaScript

Michal•665
@mbart13
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Coding bootcamp testimonials slider
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

I struggled a lot with positioning and responsivness, but I think it turned out fine. If you think something could be improved or have any other suggestions, please let me know

Community feedback

  • Joran Minjon•610
    @DrKlonkPosted over 3 years ago

    Hi Michal,

    It looks great! The responsiveness works fine and the positioning of the elements is where they should be. The code looks clean and maintainable as well!

    The main thing I think is a bit iffy, is the dependance on the transition in the updateSlide method. You now need the transition (that is defined in CSS) to always play, which is caused by adding the class in the line above it. It seems a bit strange to add an event listener in a method like this. I think I'd rather see the effect working, regardless of the transition in CSS.

    For instance, right now, setting the transition time to 0.0s breaks the change. I don't think that should happen. But maybe that's just me.

    All in all, it does work as is and in the end, you did a really good job!

    Cheers, Joran

    1
  • Michal•665
    @mbart13Posted over 3 years ago

    thanks for pointing this out, I didn't even think about it!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord