@DrKlonk
Posted
Hi Michal,
It looks great! The responsiveness works fine and the positioning of the elements is where they should be. The code looks clean and maintainable as well!
The main thing I think is a bit iffy, is the dependance on the transition in the updateSlide method. You now need the transition (that is defined in CSS) to always play, which is caused by adding the class in the line above it. It seems a bit strange to add an event listener in a method like this. I think I'd rather see the effect working, regardless of the transition in CSS.
For instance, right now, setting the transition time to 0.0s breaks the change. I don't think that should happen. But maybe that's just me.
All in all, it does work as is and in the end, you did a really good job!
Cheers, Joran
